Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN B-20316 - Pro Gear Weights in Prime V3 API #13453

Merged
merged 7 commits into from
Aug 14, 2024
Merged

MAIN B-20316 - Pro Gear Weights in Prime V3 API #13453

merged 7 commits into from
Aug 14, 2024

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Aug 13, 2024

B-20316

INT PR

Summary

Pro Gear Weights were getting added to the Prime V1 and Prime V2 APIs at the same time Prime V3 was getting created. That timing caused those fields to not make it into Prime V3. Later, the Simulator was updated to use Prime V3 in places that used Pro Gear Weights and this issue became much more noticeable. <- All of this was in tasks assigned to our team.

Brooklyn noticed this issue and fixed Prime V3 to accept and persist Pro Gear Weights. This ticket returns those stored values.

I was eager to move this to PI 24.5 so it could be fixed before Home Safe switches to V3.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the
  2. Login as a

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@ajlusk ajlusk added Scrummy Bears Scrum Team H MAIN labels Aug 13, 2024
@ajlusk ajlusk self-assigned this Aug 13, 2024
@ajlusk ajlusk marked this pull request as ready for review August 13, 2024 14:13
@ajlusk ajlusk requested a review from a team as a code owner August 13, 2024 14:13
Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed match INT.

Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@r-mettler r-mettler merged commit bdbdbf9 into main Aug 14, 2024
41 checks passed
@r-mettler r-mettler deleted the B-20316 branch August 14, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants