B-20438 and B-20440 #13572
Merged
B-20438 and B-20440 #13572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-this is to include the new react-file-viewer v1.2.4 (made for milmove app) -all tests regarding FileViewer needed to be modified to workaround some dependency issues -updated Swagger, Yarn -with this commit, milmove Office users will be able to zoom on image uploads associated with documents. They will also be able to rotate images and save the image rotation so all users (including other users) will be able to see the updated rotation.
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller
Unchanged
|
|
At the end there had to do a make clean and re-generate the swagger files |
taeJungCaci
deleted the
MAIN-B20440-amw-zoom-rotate-capability-for-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility Tickets
B-20440
B-20438
Previous PRs (into INT) Associated with this PR
Verification that it all works
If you would like to verify that rotation/zoom still works on this branch, make sure you perform the following steps to ensure it will work as designed.