-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-19809 update SC flag count to include missing orders info #13685
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commits are good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed happo, popped up 35 to look at as a result of changing the color of the $error tag to be 508 compliant
First INT PR
Second INT PR
Agility ticket
Summary
We want to include the count of missing orders information in the count of action items for both the TOO and SC when navigating the application.
We also want to replace the red exclamation with a red box with the count of missing orders info.
This PR does the following:
ServicesCounselingMoveInfo
andTXOMoveInfo
to keep track of the count of missing fields in theorders
object - this is the parent component of the components we need to use those values inMoveDetails
&ServicesCounselingMoveDetails
aaaandTXOTabNav
&ServicesCounselingTabNav
- also includes the setter functions to manage those values with auseEffect
hookTag
with color value fromcolors.scss
to maintain continuity in the applicaitonHow to test
Move Details
count tabMove Details
tabScreenshots
TOO view
SC view
508 for TOO
508 for SC