Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Po #53

Merged
merged 17 commits into from
Jun 8, 2016
Merged

Po #53

merged 17 commits into from
Jun 8, 2016

Conversation

ollandos
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.8%) to 89.994% when pulling bc74bda on po into d2cdb88 on devel.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.2%) to 89.653% when pulling 7feefb1 on po into d2cdb88 on devel.

elif not self.only_keys:
self.only_values = True
else:
raise ParseError(u"")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the silent treatment ... 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to write there as an Error message :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You have both full and empty msgstrs, make up your mind already"

@kbairak
Copy link
Member

kbairak commented May 30, 2016

I can't find something wrong here (the test suite can though)

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.2%) to 89.653% when pulling 412f2be on po into d2cdb88 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.088% when pulling 6e69cdb on po into d2cdb88 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.088% when pulling b1f7d53 on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.088% when pulling 62e4e89 on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.671% when pulling df81a0f on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.671% when pulling 6b721f2 on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.859% when pulling 67c44dc on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.859% when pulling 34ecc1f on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.11% when pulling c24fc23 on po into bca4d29 on devel.

po = polib.pofile(content)
self.only_values = False
self.only_keys = False
self.new_po = copy.copy(po)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the copy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the copy to remove the entries. If I didn't and removed an item while looping it would get fd up.

@kbairak
Copy link
Member

kbairak commented Jun 1, 2016

Looks good, I vote merge!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.113% when pulling 5484c18 on po into bca4d29 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.115% when pulling ce92e64 on po into 9475bde on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.137% when pulling f9f3908 on po into 9475bde on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.147% when pulling 1c0fe2c on po into 9475bde on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.159% when pulling f3eb78a on po into 9475bde on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.159% when pulling a1aad19 on po into 9475bde on devel.

@kbairak
Copy link
Member

kbairak commented Jun 7, 2016

@ollandos Latest changes look great!

@kbairak kbairak merged commit c7dd39d into devel Jun 8, 2016
@kbairak kbairak deleted the po branch June 8, 2016 08:39
@ollandos ollandos restored the po branch June 13, 2016 08:02
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.159% when pulling a1aad19 on po into 9475bde on devel.

@kbairak kbairak deleted the po branch August 31, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants