-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Po #53
Conversation
elif not self.only_keys: | ||
self.only_values = True | ||
else: | ||
raise ParseError(u"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the silent treatment ... 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to write there as an Error message :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"You have both full and empty msgstr
s, make up your mind already"
I can't find something wrong here (the test suite can though) |
po = polib.pofile(content) | ||
self.only_values = False | ||
self.only_keys = False | ||
self.new_po = copy.copy(po) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use the copy to remove the entries. If I didn't and removed an item while looping it would get fd up.
Looks good, I vote merge! |
@ollandos Latest changes look great! |
No description provided.