New implementation of lazy strings #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #80 +/- ##
==========================================
- Coverage 77.75% 77.42% -0.33%
==========================================
Files 37 46 +9
Lines 2841 3801 +960
==========================================
+ Hits 2209 2943 +734
- Misses 632 858 +226
Continue to review full report at Codecov.
|
kbairak
force-pushed
the
new_lazy_strings
branch
8 times, most recently
from
7100c17
to
d4e63a5
Compare
kbairak
force-pushed
the
new_lazy_strings
branch
from
d4e63a5
to
3195018
Compare
Django's makemigrations command has some trouble with our LazyStrings. When LazyStrings are used as choices in a `models.TextChoices` subclass, the migration file will either have: 1. The return value of `__repr__` 2. The underlying string, which in the initial implementation was '' We add an optional fallback_value keyword argument to be used as both the value of the underlying string and as the return value of `__repr__` so that makemigrations will produce a correct migration file.
kbairak
force-pushed
the
new_lazy_strings
branch
from
be0e110
to
81c67c3
Compare
codegaze
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #79 (hopefully).