Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded video support #41

Closed
yanyanlongxia opened this issue Feb 3, 2021 · 4 comments
Closed

Embedded video support #41

yanyanlongxia opened this issue Feb 3, 2021 · 4 comments

Comments

@yanyanlongxia
Copy link

There should be an embedded video at the bottom of the page, but there is nothing.

The original notion page
@transitive-bullshit
Copy link
Owner

This should be fixed now if you update to latest react-notion-x.

We weren't handling embedded videos aside from external YouTube videos.

@transitive-bullshit
Copy link
Owner

See this page for a live example https://react-notion-x-demo.transitivebullsh.it/file-uploads-34d650c65da34f888335dbd3ddd141dc

@transitive-bullshit transitive-bullshit changed the title The video disappeared Embedded video support Feb 4, 2021
@yanyanlongxia
Copy link
Author

Thanks. It works

@jorgearuv
Copy link
Contributor

@transitive-bullshit Found another issue with an embedded video: https://jorgeruvalcaba.dev/add-tab-to-search-in-your-gatsby-blog-e6082ecef65d4f82a333b9f62335a51a. Seems that the styles are not being applied as expected.

AbdallahEssamGaber pushed a commit to iSchoolTech/TGs-backup that referenced this issue Apr 17, 2024
@morethanmin
adding post author (transitive-bullshit#41)
942b0c4 
* feat: update typescript

* fix: build error

* refactor: refactoring code

* refactor: refactoring code

* chore: update config

* chore: update README.md

* feat: updating author property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@transitive-bullshit @jorgearuv @yanyanlongxia