Merge pull request #91 from transitland/feed-imports-log-exceptions

Feed imports log exceptions
transitland · May 29, 2015 · 2f27468 · 2f27468
2 parents bbfc2be + 8c475e8
commit 2f27468
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/app/workers/feed_eater_worker.rb b/app/workers/feed_eater_worker.rb
@@ -38,19 +38,23 @@ def perform(feed_onestop_ids = [])
           logger.info "5. Creating GTFS artifact: #{feed_onestop_id}"
           run_python('./lib/feedeater/artifact.py', "--log #{log_file_path} #{feed_onestop_id}")
           # TODO: upload GTFS artifact to S3
-          # what happens with a human-readable index.html?
-        rescue
-          logger.error $!
-          logger.error $!.backtrace
+        rescue Exception => e
+          # NOTE: we're catching all exceptions, including Interrupt, SignalException, and SyntaxError
+          exception_log = "\n#{e}\n#{e.backtrace}\n"
+          logger.error exception_log
           feed_import.update(success: false)
+          Raven.capture_exception(e) if defined?(Raven)
         else
           feed.has_been_fetched_and_imported!(on_feed_import: feed_import)
         ensure
           # Report
           if File.exist?(log_file_path)
             import_log = File.open(log_file_path, 'r').read
           else
-            import_log = nil
+            import_log = ''
+          end
+          if exception_log.present?
+            import_log << exception_log
           end
           if File.exist?(validation_report_path)
             validation_report = File.open(validation_report_path, 'r').read