ScheduleStopPair Direct Import #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
# Conflicts: # Gemfile.lock
|
Updated from master; working on imported_from_feed issues... |
irees
changed the title
# Conflicts: # Gemfile.lock
|
See updated PR body. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(PR comment by @irees)
This PR creates a fast-path for SSP imports.
Currently, SSPs go through Changesets, and are applied one-at-a-time. This change allows SSPs to be inserted directly, using multirow inserts to process 1000 at a time. Additionally, SSPs are now directly associated with Feed/FeedVersions, instead of going through the EIFF table. This results in a substantial performance improvement.
The db:migrate:migrate_eiff_ssp task runs a migration to move the Feed/FeedVersion associations from EIFFs to the SSPs, and then delete the EIFFs.
Finally, the 'active' column is dropped for SSPs, eliminating the costly and error-prone feed version activation changeover process. This is now handled by querying against Feed active_feed_versions.
One forward looking feature is to tag each FeedVersion with an import_level, which can be used to specify whether a feed is registry-only (0), schedule imported (2), available to valhalla (4), etc.
SSP includes two additional scopes: where_active, and where_import_level.
Resolves #319
Resolves #392