Migrations: Fix a broken migrations

translate · Jan 16, 2015 · 6081bbe · 6081bbe
1 parent 5092205
commit 6081bbe
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/pootle/apps/pootle_store/migrations/0021_set_reviewer_data.py b/pootle/apps/pootle_store/migrations/0021_set_reviewer_data.py
@@ -19,29 +19,25 @@ def forwards(self, orm):
 
         cur_id = None
         processed_id = None
+
         skip_types = [
             SubmissionTypes.MUTE_CHECK,
             SubmissionTypes.UNMUTE_CHECK,
             SubmissionTypes.SUGG_ADD,
             SubmissionTypes.SUGG_REJECT,
         ]
-
         for s in ss:
             if (processed_id != s.unit_id and
                 (cur_id != s.unit_id or s.type in skip_types or
                  s.field == SubmissionFields.COMMENT)):
-
                 cur_id = s.unit_id
-
-                if s.field == SubmissionFields.TARGET:
+                if s.type == SubmissionTypes.SUGG_ACCEPT:
+                    s.unit.reviewed_by = s.submitter
+                    s.unit.reviewed_on = s.creation_time
+                    s.unit.save()
+                    processed_id = cur_id
+                elif s.field == SubmissionFields.TARGET:
                     processed_id = cur_id
-
-                    if s.type == SubmissionTypes.SUGG_ACCEPT:
-                        s.submitter = s.suggestion.reviewer
-                        s.unit.reviewed_by = s.submitter
-                        s.unit.reviewed_on = s.creation_time
-                        s.save()
-                        s.unit.save()
 
     def backwards(self, orm):
         pass