Drop most of djblets and replace it by custom models to store stuff #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do way with it by subclassing Django’s Form directly.
Pick notes: Partial pick of khaledhosny/pootle@1eb6c2bd. The rest of the
changes don't apply since we dropped the ability to alter the settings
from the home page in b4d46d6.
Conflicts:
pootle/apps/pootle_app/views/admin/adminpages.py
pootle/apps/pootle_app/views/index/index.py
Also this code accomplishes the same thing and is much more easy to understand than djblets one we were using.
Exposing each separate use for siteconfig makes easier to replace it. Add functions to retrieve site title and description. This avoids us retrieving all the site config in the place where we need the title or the description.
Exposing each separate use for siteconfig makes easier to replace it. This moves the ability to save buildversion to pootle_misc. This avoids us retrieving all the site config in the place where we save the build versions.
Exposing each separate use for siteconfig makes easier to replace it. This moves the code to retrieve buildversion to pootle_misc. This avoids us retrieving the build versions in the place where we need the build versions.
Also adjust the GeneralSettingsForm to use PootleSite.
|
Yay :) Ill review this on the plane. |
|
Other than the build failure, gtm. |
|
I've only previously seen this issue when using sqlite and putting the database under load. The fact that this is now happening on all 3 supported databases is a bit of a concern :/ |
|
The last fix seems to have solved all the tests failures. If you don't have any further issue I will merge this tomorrow. |
|
@unho Please use "except Exception" instead of naked except clauses. Once that's fixed, all GTM. |
Since the previous commit the code works fine just using POOTLE_BUILDVERSION instead of BUILDVERSION. Note that this requires treating the build version as a string.
…model But keep the old functions to retrieve the data stored using djblets.
Even when saving old build versions. This requires migrate to PootleConfig ASAP on the upgrading cycle. This will allow to simplify a bit our code to save and retrieve the build versions so it only relies on the new PootleConfig.
Also drop code that is unused now that the middleware is not used.
This fixes the tests failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.