EN Picks: Fuzzy-related pickings #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless users have administration privileges, now they're required to clear the fuzzy flag. This covers the backend side of evernote/pootle#157. Conflicts: pootle/apps/pootle_store/forms.py
|
FWIW the only relevant commit for fixing the issue on 1.5 is 5a4114f. The other commits introduce unrelated behavior changes upstream might not be interested in, since they're likely to be specific to EN's needs. |
Non-admin users now have the fuzzy checkbox disabled by default. It'll be shown if the initial state of the unit is fuzzy or some other action (MT translation, auto-translation etc.) turned the unit into fuzzy state. Whenever the fuzzy checkbox is displayed for non-admins, they are forced to clear it, otherwise the submit button won't be enabled. This covers the frontend side of evernote/pootle#157.
The interpretation of values changed in the templates and the field now is getting values other than strings as well (`True`, `False` and `None`). Conflicts: tests/forms/unit.py
|
@julen We discussed those changes, we agree with them. |
|
Good to know — the description gives no clue, only mentions the issue on 1.5. |
|
Edited. |
|
I don't see any obvious issue, so GTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing 1.5 fuzzy issue and brings in evernote#157 with it.
Worth noting: https://github.com/evernote/pootle/commit/51a02b5677034f2a4c155362f33ab6e04169e52a should be picked once we no longer support 1.5