Upgrade fixes #246
Merged
Upgrade fixes #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Please review again. Ready to merge. |
This seems to be a typo when altering this code in the past.
This is a followup for the previous commit. Saving an old Translate Toolkit build version is not a problem, because when later running the upgrade for Translate Toolkit the current latest build will be saved.
Since it is the only place where it is used it makes sense to be there. This allows to keep the module __init__.py for code more focused on the upgrade machinery internals.
Just complicates the code.
So no need to convert the retrieved build version in other places.
Still wondering why this code worked.
If we get to this point we will have the build versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.