-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect duplicate step names #27
Comments
Sounds like a nice improvement! I suppose you ran into this while hammering out the shrine integration? |
I haven't encountered this error in actual, but when writing examples I realized that it's easy to accidentally give two steps with the same robot the same name. In shrine-transloadit I already added the check for unique step names. |
ifedapoolarewaju
added a commit
to ifedapoolarewaju/ruby-sdk
that referenced
this issue
May 22, 2018
ifedapoolarewaju
added a commit
to ifedapoolarewaju/ruby-sdk
that referenced
this issue
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Awesome library! One improvement came to mind. Since we're building steps as an array of objects, it would be nice for the library to detect if the user accidentally named two different steps with the same name, and raise an error. I just think that the way assemblies are built, this mistake can happen easily.
The current behaviour is probably that the latter step will silently override the previous, and I was just thinking that it would be great to explicitly let the user know that they made a mistake.
The text was updated successfully, but these errors were encountered: