Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tus,xhr-upload: emit error when companion returns error during upload creation #2166

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

ifedapoolarewaju
Copy link
Contributor

During upload instantiation, if companion returns an error, the upload-error even is not emitted, so the progress bar just waits infinitely.

Before this commit:
Kapture 2020-04-01 at 16 02 52

After this commit:
Kapture 2020-04-01 at 16 19 27

@arturi
Copy link
Contributor

arturi commented Apr 1, 2020

Nice! Do we need the same for AWS-S3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants