Remove fs stat and use bytesWritten as content length #2683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as described in this issue. I want to avoid any potential
fs.stat
delay which can be caused by infrastructure such as EFS. The best way to do it is to remove any potential delay between the creation of thereadStream
and the HTTP request to the destination.I found that
this.bytesWritten
contains the number of bytes of the file downloaded from a provider(google drive, one drive, etc.). And, because companion uploads that same file it is safe to use it ascontent-length
when uploading. In fact, the code already uses this.bytesWritten as a synonym ofbytesTotal
please let me know if there is anything that I didn't clearly explain.
cc @kvz this is a better solution than fs.statSync which I brought up on a previous PR that I closed.