Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Companion deploys #3388

Merged
merged 10 commits into from Jan 10, 2022
Merged

Fix Companion deploys #3388

merged 10 commits into from Jan 10, 2022

Conversation

kiloreux
Copy link
Contributor

@kiloreux kiloreux commented Dec 22, 2021 •
edited

@Murderlon
Copy link
Member

Seems it's not working yet?

@kiloreux
Copy link
Contributor Author

Heroku was down for a long time yesterday. Which didn't allow me to try as I wanted. I am planning on tackling it today and I will update the channel once we have something 👍

@kiloreux
Copy link
Contributor Author

kiloreux commented Jan 9, 2022

Tested a deployment successfully https://github.com/transloadit/uppy/actions/runs/1674980731

This switches to docker. I only added a bit of work on top of @mifi detailed issue #3362. So if there's any credit for this fix it should be his.

@kiloreux kiloreux linked an issue Jan 10, 2022 that may be closed by this pull request
Companion heroku deployment broken #3362
Closed
2 tasks
mifi
mifi reviewed Jan 10, 2022
View reviewed changes
Copy link
Contributor

@mifi mifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! It's good that we can dogfood our own dockerfile now in heroku.

.github/workflows/companion-deploy.yml Outdated Show resolved Hide resolved
@kiloreux @mifi
Update .github/workflows/companion-deploy.yml
a15f2be 
Co-authored-by: Mikael Finstad <finstaden@gmail.com>
@kiloreux
Copy link
Contributor Author

I will go ahead and merge it. Can always have a hindsight review.

@kiloreux kiloreux merged commit fee5ad9 into main Jan 10, 2022
@kiloreux kiloreux deleted the companion-docker branch January 10, 2022 10:03
@github-actions github-actions bot mentioned this pull request Jan 10, 2022
Merged
github-actions bot added a commit that referenced this pull request Jan 10, 2022
@github-actions
Release: uppy@2.4.0 (#3420)
0fc3336 
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/drag-drop      |   2.0.6 | @uppy/tus            |   2.2.0 |
| @uppy/image-editor   |   1.1.1 | @uppy/utils          |   4.0.5 |
| @uppy/screen-capture |   2.0.6 | @uppy/robodog        |   2.2.0 |
| @uppy/transloadit    |   2.1.0 | uppy                 |   2.4.0 |

- @uppy/transloadit: ignore rate limiting errors when polling (Antoine du Hamel / #3418)
- @uppy/tus: pause all requests in response to server rate limiting (Antoine du Hamel / #3394)
- @uppy/transloadit: better defaults for rate limiting (Antoine du Hamel / #3414)
- @uppy/companion: Fix Companion deploys (kiloreux / #3388)
- meta: update aws-presigned-url example to use esm (Antoine du Hamel / #3413)
- @uppy/image-editor: namespace input range css (Merlijn Vos / #3406)
- @uppy/screen-capture: Add missing option to the screen capture types (Mustafa Navruz / #3400)
- @uppy/drag-drop: fix `undefined is not a function` TypeError (Antoine du Hamel / #3397)
- website: update december 2021 blog post (Antoine du Hamel / #3396)
- website: Polished the latest update blog (AJvanLoon / #3390)
- website: docs: fix typo in audio.md (heocoi / #3389)
- website: 2.0-2.3 post draft (Artur Paikin / #3370)
Murderlon added a commit that referenced this pull request Jan 12, 2022
@Murderlon
Merge branch 'main' into cypress
978e53e 
* main:
  dev: move configuration to a `.env` file (#3430)
  Update ci.yml (#3428)
  @uppy/transloadit: simplify `#onTusError` (#3419)
  Force include babel numeric separator (#3422)
  Release: uppy@2.4.0 (#3420)
  @uppy/transloadit: ignore rate limiting errors when polling (#3418)
  @uppy/tus: pause all requests in response to server rate limiting (#3394)
  @uppy/transloadit: better defaults for rate limiting (#3414)
  Update BACKLOG.md
  Fix Companion deploys (#3388)
  update aws-presigned-url example to use esm (#3413)
  @uppy/image-editor: namespace input range css (#3406)
  Release: uppy@2.3.3 (#3410)
  improve private ip check (#3403)
  Add missing option to the screen capture types (#3400)
  @uppy/drag-drop: fix `undefined is not a function` TypeError (#3397)
  website: update december 2021 blog post (#3396)
vymao pushed a commit to vymao/uppy that referenced this pull request Mar 29, 2022
@Murderlon
Merge branch 'main' into cypress
e9d1dea 
* main:
  dev: move configuration to a `.env` file (transloadit#3430)
  Update ci.yml (transloadit#3428)
  @uppy/transloadit: simplify `#onTusError` (transloadit#3419)
  Force include babel numeric separator (transloadit#3422)
  Release: uppy@2.4.0 (transloadit#3420)
  @uppy/transloadit: ignore rate limiting errors when polling (transloadit#3418)
  @uppy/tus: pause all requests in response to server rate limiting (transloadit#3394)
  @uppy/transloadit: better defaults for rate limiting (transloadit#3414)
  Update BACKLOG.md
  Fix Companion deploys (transloadit#3388)
  update aws-presigned-url example to use esm (transloadit#3413)
  @uppy/image-editor: namespace input range css (transloadit#3406)
  Release: uppy@2.3.3 (transloadit#3410)
  improve private ip check (transloadit#3403)
  Add missing option to the screen capture types (transloadit#3400)
  @uppy/drag-drop: fix `undefined is not a function` TypeError (transloadit#3397)
  website: update december 2021 blog post (transloadit#3396)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@kiloreux @mifi
Fix Companion deploys (transloadit#3388)
b21164b 
* Change compilation to postinstall

* Deploy

* Restore shape

* Reduce builds

* Use docker instead

* Use port as second variable

* Change

* Minor fixes

* Update .github/workflows/companion-deploy.yml

Co-authored-by: Mikael Finstad <finstaden@gmail.com>

Co-authored-by: Mikael Finstad <finstaden@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mifi mifi mifi left review comments

@Murderlon Murderlon Murderlon approved these changes

@juliangruber juliangruber Awaiting requested review from juliangruber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Companion heroku deployment broken
3 participants
@kiloreux @Murderlon @mifi