Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/transloadit: ignore rate limiting errors when polling #3418

Merged
merged 1 commit into from Jan 10, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Jan 10, 2022

Fixes: #3156

@aduh95 aduh95 requested a review from arturi January 10, 2022 16:54
@@ -79,11 +79,6 @@ class TransloaditAssembly extends Emitter {
this.emit('connect')
})

socket.on('connect_failed', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it never fires, outdated event?

@aduh95 aduh95 merged commit e2c6259 into main Jan 10, 2022
@aduh95 aduh95 deleted the rate-limited-polling branch January 10, 2022 18:36
@github-actions github-actions bot mentioned this pull request Jan 10, 2022
github-actions bot added a commit that referenced this pull request Jan 10, 2022
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/drag-drop      |   2.0.6 | @uppy/tus            |   2.2.0 |
| @uppy/image-editor   |   1.1.1 | @uppy/utils          |   4.0.5 |
| @uppy/screen-capture |   2.0.6 | @uppy/robodog        |   2.2.0 |
| @uppy/transloadit    |   2.1.0 | uppy                 |   2.4.0 |

- @uppy/transloadit: ignore rate limiting errors when polling (Antoine du Hamel / #3418)
- @uppy/tus: pause all requests in response to server rate limiting (Antoine du Hamel / #3394)
- @uppy/transloadit: better defaults for rate limiting (Antoine du Hamel / #3414)
- @uppy/companion: Fix Companion deploys (kiloreux / #3388)
- meta: update aws-presigned-url example to use esm (Antoine du Hamel / #3413)
- @uppy/image-editor: namespace input range css (Merlijn Vos / #3406)
- @uppy/screen-capture: Add missing option to the screen capture types (Mustafa Navruz / #3400)
- @uppy/drag-drop: fix `undefined is not a function` TypeError (Antoine du Hamel / #3397)
- website: update december 2021 blog post (Antoine du Hamel / #3396)
- website: Polished the latest update blog (AJvanLoon / #3390)
- website: docs: fix typo in audio.md (heocoi / #3389)
- website: 2.0-2.3 post draft (Artur Paikin / #3370)
Murderlon added a commit that referenced this pull request Jan 12, 2022
* main:
  dev: move configuration to a `.env` file (#3430)
  Update ci.yml (#3428)
  @uppy/transloadit: simplify `#onTusError` (#3419)
  Force include babel numeric separator (#3422)
  Release: uppy@2.4.0 (#3420)
  @uppy/transloadit: ignore rate limiting errors when polling (#3418)
  @uppy/tus: pause all requests in response to server rate limiting (#3394)
  @uppy/transloadit: better defaults for rate limiting (#3414)
  Update BACKLOG.md
  Fix Companion deploys (#3388)
  update aws-presigned-url example to use esm (#3413)
  @uppy/image-editor: namespace input range css (#3406)
  Release: uppy@2.3.3 (#3410)
  improve private ip check (#3403)
  Add missing option to the screen capture types (#3400)
  @uppy/drag-drop: fix `undefined is not a function` TypeError (#3397)
  website: update december 2021 blog post (#3396)
vymao pushed a commit to vymao/uppy that referenced this pull request Mar 29, 2022
* main:
  dev: move configuration to a `.env` file (transloadit#3430)
  Update ci.yml (transloadit#3428)
  @uppy/transloadit: simplify `#onTusError` (transloadit#3419)
  Force include babel numeric separator (transloadit#3422)
  Release: uppy@2.4.0 (transloadit#3420)
  @uppy/transloadit: ignore rate limiting errors when polling (transloadit#3418)
  @uppy/tus: pause all requests in response to server rate limiting (transloadit#3394)
  @uppy/transloadit: better defaults for rate limiting (transloadit#3414)
  Update BACKLOG.md
  Fix Companion deploys (transloadit#3388)
  update aws-presigned-url example to use esm (transloadit#3413)
  @uppy/image-editor: namespace input range css (transloadit#3406)
  Release: uppy@2.3.3 (transloadit#3410)
  improve private ip check (transloadit#3403)
  Add missing option to the screen capture types (transloadit#3400)
  @uppy/drag-drop: fix `undefined is not a function` TypeError (transloadit#3397)
  website: update december 2021 blog post (transloadit#3396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canceled/failed upload to transloadit keeps polling assembly
2 participants