Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force include babel numeric separator #3422

Merged
merged 1 commit into from Jan 11, 2022
Merged

Force include babel numeric separator #3422

merged 1 commit into from Jan 11, 2022

Conversation

Murderlon
Copy link
Member

Fixes #3421

It's interesting that this needs to be explicitly included, just like nullish coalescing, in order for it to work.

@Murderlon Murderlon requested a review from aduh95 January 11, 2022 09:38
Copy link
Member

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to rethink our Babel config at some point, relying on Browserlist may not be the optimum way now that bundlers are lagging behind browsers.

@Murderlon Murderlon merged commit 274a3a0 into main Jan 11, 2022
@Murderlon Murderlon deleted the numeric-separator branch January 11, 2022 10:30
Murderlon added a commit that referenced this pull request Jan 12, 2022
* main:
  dev: move configuration to a `.env` file (#3430)
  Update ci.yml (#3428)
  @uppy/transloadit: simplify `#onTusError` (#3419)
  Force include babel numeric separator (#3422)
  Release: uppy@2.4.0 (#3420)
  @uppy/transloadit: ignore rate limiting errors when polling (#3418)
  @uppy/tus: pause all requests in response to server rate limiting (#3394)
  @uppy/transloadit: better defaults for rate limiting (#3414)
  Update BACKLOG.md
  Fix Companion deploys (#3388)
  update aws-presigned-url example to use esm (#3413)
  @uppy/image-editor: namespace input range css (#3406)
  Release: uppy@2.3.3 (#3410)
  improve private ip check (#3403)
  Add missing option to the screen capture types (#3400)
  @uppy/drag-drop: fix `undefined is not a function` TypeError (#3397)
  website: update december 2021 blog post (#3396)
@github-actions github-actions bot mentioned this pull request Jan 12, 2022
github-actions bot added a commit that referenced this pull request Jan 12, 2022
| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/transloadit |   2.1.1 | uppy              |   2.4.1 |
| @uppy/robodog     |   2.2.1 |                   |         |

- @uppy/transloadit: fix handling of Tus errors and rate limiting (Antoine du Hamel / #3429)
- meta: Add Unsplash to website dashboard example (Merlijn Vos / #3431)
- meta: dev: move configuration to a `.env` file (Antoine du Hamel / #3430)
- meta: Update ci.yml (Kevin van Zonneveld / #3428)
- @uppy/transloadit: simplify `#onTusError` (Antoine du Hamel / #3419)
- meta: Force include babel numeric separator (Merlijn Vos / #3422)
vymao pushed a commit to vymao/uppy that referenced this pull request Mar 29, 2022
* main:
  dev: move configuration to a `.env` file (transloadit#3430)
  Update ci.yml (transloadit#3428)
  @uppy/transloadit: simplify `#onTusError` (transloadit#3419)
  Force include babel numeric separator (transloadit#3422)
  Release: uppy@2.4.0 (transloadit#3420)
  @uppy/transloadit: ignore rate limiting errors when polling (transloadit#3418)
  @uppy/tus: pause all requests in response to server rate limiting (transloadit#3394)
  @uppy/transloadit: better defaults for rate limiting (transloadit#3414)
  Update BACKLOG.md
  Fix Companion deploys (transloadit#3388)
  update aws-presigned-url example to use esm (transloadit#3413)
  @uppy/image-editor: namespace input range css (transloadit#3406)
  Release: uppy@2.3.3 (transloadit#3410)
  improve private ip check (transloadit#3403)
  Add missing option to the screen capture types (transloadit#3400)
  @uppy/drag-drop: fix `undefined is not a function` TypeError (transloadit#3397)
  website: update december 2021 blog post (transloadit#3396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppy 2.4.0: Webpack fails to compile due to error: "Module parse failed: Identifier directly after number"
2 participants