dev: move configuration to a .env file
#3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting the dev config in a git-ignored files improves DX and lower the risk of a private dev key being commited by mistake.
Murderlon
reviewed
Jan 11, 2022
.env.development
Outdated
| @@ -0,0 +1,24 @@ | |||
| VITE_UPLOADER=tus | |||
|
|
|||
| #### To customize this, create a .env.dev.local file that overrides those values | |||
There was a problem hiding this comment.
nit: it's .env.development but .env.dev.local (instead of both dev or both development)
Murderlon
approved these changes
Jan 11, 2022
Murderlon
pushed a commit
that referenced
this pull request
Jan 11, 2022
Murderlon
added a commit
that referenced
this pull request
Jan 12, 2022
* main: dev: move configuration to a `.env` file (#3430) Update ci.yml (#3428) @uppy/transloadit: simplify `#onTusError` (#3419) Force include babel numeric separator (#3422) Release: uppy@2.4.0 (#3420) @uppy/transloadit: ignore rate limiting errors when polling (#3418) @uppy/tus: pause all requests in response to server rate limiting (#3394) @uppy/transloadit: better defaults for rate limiting (#3414) Update BACKLOG.md Fix Companion deploys (#3388) update aws-presigned-url example to use esm (#3413) @uppy/image-editor: namespace input range css (#3406) Release: uppy@2.3.3 (#3410) improve private ip check (#3403) Add missing option to the screen capture types (#3400) @uppy/drag-drop: fix `undefined is not a function` TypeError (#3397) website: update december 2021 blog post (#3396)
Merged
github-actions bot
added a commit
that referenced
this pull request
Jan 12, 2022
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/transloadit | 2.1.1 | uppy | 2.4.1 | | @uppy/robodog | 2.2.1 | | | - @uppy/transloadit: fix handling of Tus errors and rate limiting (Antoine du Hamel / #3429) - meta: Add Unsplash to website dashboard example (Merlijn Vos / #3431) - meta: dev: move configuration to a `.env` file (Antoine du Hamel / #3430) - meta: Update ci.yml (Kevin van Zonneveld / #3428) - @uppy/transloadit: simplify `#onTusError` (Antoine du Hamel / #3419) - meta: Force include babel numeric separator (Merlijn Vos / #3422)
vymao
pushed a commit
to vymao/uppy
that referenced
this pull request
Mar 29, 2022
* main: dev: move configuration to a `.env` file (transloadit#3430) Update ci.yml (transloadit#3428) @uppy/transloadit: simplify `#onTusError` (transloadit#3419) Force include babel numeric separator (transloadit#3422) Release: uppy@2.4.0 (transloadit#3420) @uppy/transloadit: ignore rate limiting errors when polling (transloadit#3418) @uppy/tus: pause all requests in response to server rate limiting (transloadit#3394) @uppy/transloadit: better defaults for rate limiting (transloadit#3414) Update BACKLOG.md Fix Companion deploys (transloadit#3388) update aws-presigned-url example to use esm (transloadit#3413) @uppy/image-editor: namespace input range css (transloadit#3406) Release: uppy@2.3.3 (transloadit#3410) improve private ip check (transloadit#3403) Add missing option to the screen capture types (transloadit#3400) @uppy/drag-drop: fix `undefined is not a function` TypeError (transloadit#3397) website: update december 2021 blog post (transloadit#3396)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting the dev config in a git-ignored files improves DX and lower the
risk of a private dev key being commited by mistake.