Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use user-preferred locale #5444

Merged
merged 3 commits into from
Apr 27, 2023
Merged

fix: use user-preferred locale #5444

merged 3 commits into from
Apr 27, 2023

Conversation

mikedld
Copy link
Member

@mikedld mikedld commented Apr 24, 2023

Previous fix adding L format specifier was correct but only fixed half of the problem, as C++ locale is set up to be "C" by default. GTK client used to call setlocale(LC_ALL, "") to set up user-preferred locale which only affected C functions and std::locale (used by libfmt) was unaware of those changes.

Apply the fix to all the binaries since they're all doing some sort of output to the user and calling libtransmission helpers, as well as using libfmt directly.

Fixes: #5284

@mikedld mikedld changed the title Bugfix/gh5284 user locale Use user-preferred locale Apr 24, 2023
@mikedld @ckerr
Use user-preferred locale
36302e3 
Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.

Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.
@mikedld @ckerr
Improve libtransmission's json-test
b636d0b 
Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.
@mikedld @ckerr
Improve transmission-show test runner script
437cb18 
Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
@ckerr ckerr force-pushed the bugfix/gh5284-user-locale branch from dba7490 to 437cb18 Compare April 27, 2023 05:14
@ckerr ckerr changed the title Use user-preferred locale fix: use user-preferred locale Apr 27, 2023
@ckerr
Copy link
Member

ckerr commented Apr 27, 2023

Notes: Fixed bug that caused the wrong decimal separator to be used in some locales.

@ckerr ckerr merged commit e8fcb02 into main Apr 27, 2023
20 checks passed
@ckerr ckerr deleted the bugfix/gh5284-user-locale branch April 27, 2023 14:10
ckerr pushed a commit that referenced this pull request Apr 27, 2023
@mikedld @ckerr
fix: use user-preferred locale (#5444)
411b66c 
* Use user-preferred locale

Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.

Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.

* Improve libtransmission's json-test

Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.

* Improve transmission-show test runner script

Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
@ckerr ckerr mentioned this pull request May 8, 2023
Closed
mtremer pushed a commit to ipfire/ipfire-2.x that referenced this pull request Aug 30, 2023
@mtremer
transmission: Update to version 4.0.4
21a7854 
- Update from version 4.0.3 to 4.0.4
- Update of rootfile not required.
- Changelog
Transmission 4.0.4
	This is a bugfix-only release. Everyone's feedback on 4.0.x has been very helpful -- thanks for all the suggestions, bug reports, and pull requests!
What's New in 4.0.4
All Platforms
	* Fixed bug in sending torrent metadata to peers. ([#5460](transmission/transmission#5460))
	* Avoid unnecessary heap memory allocations. ([#5520](transmission/transmission#5520), [#5527](transmission/transmission#5527))
	* Fixed filename collision edge case when renaming files. ([#5563](transmission/transmission#5563))
	* Fixed locale errors that broke number rounding when displaying statistics, e.g. upload / download ratios. ([#5587](transmission/transmission#5587))
	* Always use a fixed-length key query in tracker announces. This isn't required by the [spec](https://www.bittorrent.org/beps/bep_0007.html), but some trackers rely on that fixed length because it's common practice by other BitTorrent clients. ([#5652](transmission/transmission#5652))
	* Fixed potential Windows crash when [getstdhandle()](https://learn.microsoft.com/en-us/windows/console/getstdhandle) returns `NULL`. ([#5675](transmission/transmission#5675))
	* Fixed `4.0.0` bug where the port numbers in LDP announces are sometimes malformed. ([#5825](transmission/transmission#5825))
	* Fixed a bug that prevented editing the query part of a tracker URL. ([#5871](transmission/transmission#5871))
	* Fixed a bug where Transmission may not announce LPD on its listening interface. ([#5896](transmission/transmission#5896))
	* Made small performance improvements in libtransmission. ([#5715](transmission/transmission#5715))
macOS Client
	* Updated code that had been using deprecated API. ([#5633](transmission/transmission#5633))
Qt Client
	* Fixed torrent name rendering when showing magnet links in compact view. ([#5491](transmission/transmission#5491))
	* Fixed bug that broke the "Move torrent file to trash" setting. ([#5505](transmission/transmission#5505))
	* Fixed Qt 6.4 deprecation warning. ([#5552](transmission/transmission#5552))
	* Fixed poor resolution of Qt application icon. ([#5570](transmission/transmission#5570))
GTK Client
	* Fixed missing 'Remove torrent' tooltip. ([#5777](transmission/transmission#5777))
Web Client
	* Don't show `null` as a tier name in the inspector's tier list. ([#5462](transmission/transmission#5462))
	* Fixed truncated play / pause icons. ([#5771](transmission/transmission#5771))
	* Fixed overflow when rendering peer lists and made speed indicators honor `prefers-color-scheme` media queries. ([#5814](transmission/transmission#5814))
	* Made the main menu accessible even on smaller displays. ([#5827](transmission/transmission#5827))
transmission-cli
	* Fixed "no such file or directory" warning when adding a magnet link. ([#5426](transmission/transmission#5426))
	* Fixed bug that caused the wrong decimal separator to be used in some locales. ([#5444](transmission/transmission#5444))
transmission-remote
	* Fixed display bug that failed to show some torrent labels. ([#5572](transmission/transmission#5572))
Everything Else
	* Ran all PNG files through lossless compressors to make them smaller. ([#5586](transmission/transmission#5586))
	* Fixed potential build issue when compiling on macOS with gcc. ([#5632](transmission/transmission#5632))

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
@tearfur tearfur mentioned this pull request Sep 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope:cli scope:core scope:create scope:daemon scope:edit scope:gtk scope:mac scope:qt scope:remote scope:show type:fix A bug fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong decimal separator on locales using a comma
2 participants
@mikedld @ckerr