fix: bug that prevented providing the final metadata piece #5460
Conversation
Fixes bug in implementation of BEP 9 Xref: https://www.bittorrent.org/beps/bep_0009.html
ckerr
added
scope:core
type:fix
macos-11 CI failure is unrelated to this PR |
Fixes bug in implementation of BEP 9 Xref: https://www.bittorrent.org/beps/bep_0009.html
|
This is a critical fix. Doesn't it deserve a new release ASAP? |
|
This is a very critical fix because the very common use case of creating a torrent and sharing it via magnet link is completely broken in 4.0.x. I love Transmission so I've been using 4.0.3 with the patch manually applied from this PR for a while now. But it wasn't straightforward debugging the problem and finding the right fix as a user of Transmission. Downgrading to 3.0 was not an option because all my v1/v2 hybrid torrents would stop working. I'm afraid other users in my situation might move away from Transmission to using another product 😔 Looks like the 4.0.x and 4.1 milestones are still incomplete so a new release (4.0.4) should be pushed out ASAP with this fix. |
|
I agree, but I'm not in control of the release schedule. Last time I heard the tentative release date for "the next version" is Aug 8, which already passed. |
|
@tearfur I know, but you have more influence in this project and maybe you can help convince Charles to create a release with this PR. I'm making this request for the benefit of this project, there's no selfish motive because I'm already unblocked 😃 |
|
@shivanshu3 release notes for 4.0.4 are being prepared by Charles so it is coming soon. https://github.com/transmission/transmission/blob/docs/new-4.0.4.md/news/news-4.0.4.md |
- Update from version 4.0.3 to 4.0.4 - Update of rootfile not required. - Changelog Transmission 4.0.4 This is a bugfix-only release. Everyone's feedback on 4.0.x has been very helpful -- thanks for all the suggestions, bug reports, and pull requests! What's New in 4.0.4 All Platforms * Fixed bug in sending torrent metadata to peers. ([#5460](transmission/transmission#5460)) * Avoid unnecessary heap memory allocations. ([#5520](transmission/transmission#5520), [#5527](transmission/transmission#5527)) * Fixed filename collision edge case when renaming files. ([#5563](transmission/transmission#5563)) * Fixed locale errors that broke number rounding when displaying statistics, e.g. upload / download ratios. ([#5587](transmission/transmission#5587)) * Always use a fixed-length key query in tracker announces. This isn't required by the [spec](https://www.bittorrent.org/beps/bep_0007.html), but some trackers rely on that fixed length because it's common practice by other BitTorrent clients. ([#5652](transmission/transmission#5652)) * Fixed potential Windows crash when [getstdhandle()](https://learn.microsoft.com/en-us/windows/console/getstdhandle) returns `NULL`. ([#5675](transmission/transmission#5675)) * Fixed `4.0.0` bug where the port numbers in LDP announces are sometimes malformed. ([#5825](transmission/transmission#5825)) * Fixed a bug that prevented editing the query part of a tracker URL. ([#5871](transmission/transmission#5871)) * Fixed a bug where Transmission may not announce LPD on its listening interface. ([#5896](transmission/transmission#5896)) * Made small performance improvements in libtransmission. ([#5715](transmission/transmission#5715)) macOS Client * Updated code that had been using deprecated API. ([#5633](transmission/transmission#5633)) Qt Client * Fixed torrent name rendering when showing magnet links in compact view. ([#5491](transmission/transmission#5491)) * Fixed bug that broke the "Move torrent file to trash" setting. ([#5505](transmission/transmission#5505)) * Fixed Qt 6.4 deprecation warning. ([#5552](transmission/transmission#5552)) * Fixed poor resolution of Qt application icon. ([#5570](transmission/transmission#5570)) GTK Client * Fixed missing 'Remove torrent' tooltip. ([#5777](transmission/transmission#5777)) Web Client * Don't show `null` as a tier name in the inspector's tier list. ([#5462](transmission/transmission#5462)) * Fixed truncated play / pause icons. ([#5771](transmission/transmission#5771)) * Fixed overflow when rendering peer lists and made speed indicators honor `prefers-color-scheme` media queries. ([#5814](transmission/transmission#5814)) * Made the main menu accessible even on smaller displays. ([#5827](transmission/transmission#5827)) transmission-cli * Fixed "no such file or directory" warning when adding a magnet link. ([#5426](transmission/transmission#5426)) * Fixed bug that caused the wrong decimal separator to be used in some locales. ([#5444](transmission/transmission#5444)) transmission-remote * Fixed display bug that failed to show some torrent labels. ([#5572](transmission/transmission#5572)) Everything Else * Ran all PNG files through lossless compressors to make them smaller. ([#5586](transmission/transmission#5586)) * Fixed potential build issue when compiling on macOS with gcc. ([#5632](transmission/transmission#5632)) Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Fixes off-by-one bug in BEP 9 implementation that prevented the final piece of metadata from being sent.
Affects
4.0.0through4.0.3.Notes: Fixed bug in sending torrent metadata to peers.