fix: does not trash added torrent files when asked #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
scope:qt
type:fix
Make the patch minimal to ensure it is semver/patch
|
Notes: Fixed bug that broke the "Move torrent file to trash" setting. |
sfan5
reviewed
May 11, 2023
| } | ||
| else | ||
| { | ||
| file.rename(QStringLiteral("%1.added").arg(filename)); |
There was a problem hiding this comment.
Question: why does it rename the file at all? This is not something I, as an user, expect or want. It looks like this can't be disabled either.
mtremer
pushed a commit
to ipfire/ipfire-2.x
that referenced
this pull request
Aug 30, 2023
- Update from version 4.0.3 to 4.0.4 - Update of rootfile not required. - Changelog Transmission 4.0.4 This is a bugfix-only release. Everyone's feedback on 4.0.x has been very helpful -- thanks for all the suggestions, bug reports, and pull requests! What's New in 4.0.4 All Platforms * Fixed bug in sending torrent metadata to peers. ([#5460](transmission/transmission#5460)) * Avoid unnecessary heap memory allocations. ([#5520](transmission/transmission#5520), [#5527](transmission/transmission#5527)) * Fixed filename collision edge case when renaming files. ([#5563](transmission/transmission#5563)) * Fixed locale errors that broke number rounding when displaying statistics, e.g. upload / download ratios. ([#5587](transmission/transmission#5587)) * Always use a fixed-length key query in tracker announces. This isn't required by the [spec](https://www.bittorrent.org/beps/bep_0007.html), but some trackers rely on that fixed length because it's common practice by other BitTorrent clients. ([#5652](transmission/transmission#5652)) * Fixed potential Windows crash when [getstdhandle()](https://learn.microsoft.com/en-us/windows/console/getstdhandle) returns `NULL`. ([#5675](transmission/transmission#5675)) * Fixed `4.0.0` bug where the port numbers in LDP announces are sometimes malformed. ([#5825](transmission/transmission#5825)) * Fixed a bug that prevented editing the query part of a tracker URL. ([#5871](transmission/transmission#5871)) * Fixed a bug where Transmission may not announce LPD on its listening interface. ([#5896](transmission/transmission#5896)) * Made small performance improvements in libtransmission. ([#5715](transmission/transmission#5715)) macOS Client * Updated code that had been using deprecated API. ([#5633](transmission/transmission#5633)) Qt Client * Fixed torrent name rendering when showing magnet links in compact view. ([#5491](transmission/transmission#5491)) * Fixed bug that broke the "Move torrent file to trash" setting. ([#5505](transmission/transmission#5505)) * Fixed Qt 6.4 deprecation warning. ([#5552](transmission/transmission#5552)) * Fixed poor resolution of Qt application icon. ([#5570](transmission/transmission#5570)) GTK Client * Fixed missing 'Remove torrent' tooltip. ([#5777](transmission/transmission#5777)) Web Client * Don't show `null` as a tier name in the inspector's tier list. ([#5462](transmission/transmission#5462)) * Fixed truncated play / pause icons. ([#5771](transmission/transmission#5771)) * Fixed overflow when rendering peer lists and made speed indicators honor `prefers-color-scheme` media queries. ([#5814](transmission/transmission#5814)) * Made the main menu accessible even on smaller displays. ([#5827](transmission/transmission#5827)) transmission-cli * Fixed "no such file or directory" warning when adding a magnet link. ([#5426](transmission/transmission#5426)) * Fixed bug that caused the wrong decimal separator to be used in some locales. ([#5444](transmission/transmission#5444)) transmission-remote * Fixed display bug that failed to show some torrent labels. ([#5572](transmission/transmission#5572)) Everything Else * Ran all PNG files through lossless compressors to make them smaller. ([#5586](transmission/transmission#5586)) * Fixed potential build issue when compiling on macOS with gcc. ([#5632](transmission/transmission#5632)) Signed-off-by: Adolf Belka <adolf.belka@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5290.