Issues found in alfa test of the website

[sandervh14]

I just tested our website locally. The experience is already great! 😄 The website and backend work well together.

I think there are some small but important changes though we need to make to make it better:
[x] sort motions on descending occurence date
[x] many plenaries are missing in the plenary list on the website, whereas they are in our plenaries.json, can you investigate what goes wrong?

[sandervh14]

Joaquim mentioned in the website alfa test issues that the following requires back-end changes:

[ ] - The ID in the plenary title can just be 304, instead of 55_304. All plenaries visible in one screen are from the same political term, and there's the date on the right too.

[ ] - ID of the motions on the Plenaries page (the blue underlined links): can you make this just "Voorstel 26, stemming 1" (and French translation) instead of "55_304_mg_26_m0"?

It's not clear to me what exactly is needed at this moment. To be investigated.

[sandervh14]

These turned out to be unexpected behavior in the front-end that needed backend changes:

[x] - UX: when the Plenaries page is activated, search does not work. Do you want the displayed plenaries, motion counts and displayed motions to be filtered? Or do you intend on searching to activate the motions page, with motions filtered?
[ ] - UX: with French language selected, searching on a typed keyword in French does not work.
[/] - UX: clicking the "impôts" keyword does not lead to a working search. // Not sure if the problem is due to French characters. As quick solution, I changed the word.

Guido will take a look at these.

[idotj]

Concerning the two points about renaming ID... I added a comment for the same issue in website repo.
Copy/paste here my comment:

*Changing the ID to a more readable title is possible in the frontend, but if it is feasible to include that information in the data model it would be much more efficient than doing it via Typescript.

[sandervh14]

New ones:
[ ] searching on plenary number or plenary date does not work
[ ] search: trim spaces at end, due to accepting auto-suggest + auto-space append for words typed on smartphone
[ ] search keyword on plenaries page does not filter the displayed motions within motion groups.
[ ] search on keywords Israël, Oekraïne, impôts not working

[GuidoDechamps]

The unicode characters as they are stored in the data do get translated properly and search properly. A search for Oekraïne, réunion works.

[GuidoDechamps]

plenary date is more difficult to much. To we expect that users type the date in the correct format? In which format? I think the serach field there is insufficient and we require a date picker when searching for dates.

[GuidoDechamps]

Don't understand this: trim spaces at end, due to accepting auto-suggest + auto-space append for words typed on smartphone

but searchterms will get trimmed

[GuidoDechamps]

The search button in the frontend currently block doing a search when there are "strange" characters in there. I fixed the regular expression to accept more

[sandervh14]

The search button in the frontend currently block doing a search when there are "strange" characters in there. I fixed the regular expression to accept more

Oh. Did they implement some sort of SQL injection protection or something? I don't really see the point of checking on the frontend whether a search term is legit or not. Or is there a good reason I'm not seeing?

[GuidoDechamps]

You want to avoid that they can inject code or garbage. I simple extended the regular expression somehwat.

[sandervh14]

You want to avoid that they can inject code or garbage. I simple extended the regular expression somehwat.

OK. Fine. :-)

[GuidoDechamps]

"search keyword on plenaries page does not filter the displayed motions within motion groups." Sometimes the keyword is only in the motion groups. So if a motiongroup or one of its motions contains the keyword "guido", then it should be returned when searching for plenaries with keyword "guido". The other motiongroups for the plenary should not be displayed when it is the result of a search. When a plenary is retrieved by id, then everything of the plenary is returned.

[GuidoDechamps]

And added motiongroups to the FE in plenary. This wan't the case yet.

[sandervh14]

plenary date is more difficult to much. To we expect that users type the date in the correct format? In which format? I think the serach field there is insufficient and we require a date picker when searching for dates.

The date picker is an option too. (1) If allowing them to type in the search field, I think it makes sense to expect them to type it in the format that we also display it on our page: dd-mm-yyyy. (2) Feel free to chose between (1) and (2) as solution!

[GuidoDechamps]

2 will work now that i changed the search field. just not user friendly :)

[sandervh14]

2 will work now that i changed the search field. just not user friendly :)

I'll create a new, lower-prio ticket for that in the front-end.

[sandervh14]

Don't understand this: trim spaces at end, due to accepting auto-suggest + auto-space append for words typed on smartphone
but searchterms will get trimmed

Cool. INdeed. I just retested, this works.

[sandervh14]

"search keyword on plenaries page does not filter the displayed motions within motion groups." Sometimes the keyword is only in the motion groups. So if a motiongroup or one of its motions contains the keyword "guido", then it should be returned when searching for plenaries with keyword "guido". The other motiongroups for the plenary should not be displayed when it is the result of a search. When a plenary is retrieved by id, then everything of the plenary is returned.

Oh, ok. Didn't notice that. Good, then. :-)

[sandervh14]

Then I think this one is still remaining:

[ ] - The ID in the plenary title can just be 304, instead of 55_304. All plenaries visible in one screen are from the same political term, and there's the date on the right too.

Unless it's fixed but not deployed yet.

[GuidoDechamps]

Not necessarily true. Search for a keyword can result multple plenaries form diffeent legislatures. But if should be made more readable I agree.