Fix line endings & add docker build warnings #12
Conversation
docker/Dockerfile
Outdated
| RUN test -f /rodhaj/bot/.env \ | ||
| || (echo "Environment file not found; please copy .env to bot/.env"; exit 1) |
There was a problem hiding this comment.
The idea of having the .env file is to only use it during the development lifecycle, and during prod, all we have to do is to pass in a pre-determined .env and populate the container with the env.
Although I did say Windows development is not really supported, it should be fine to develop on as i checked and all wheels are built also for windows. Winloop is used in place of uvloop in order to aid with Windows support. Note that I haven't tested it on Windows, hence the warning
There was a problem hiding this comment.
Wait. Do you want me to remove this line or modify it somehow?
There was a problem hiding this comment.
Basically in a nutshell, I'm just saying you should remove it. (The bot will actually read off of the environment variables set in the shell if it can't find the .env file)
jamievlin
force-pushed
the
dev/jamievlin/fix-sh-lineends
branch
from
c6edb68
to
9b8b8e2
Compare
No description provided.