Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better extension/library watchdog #58

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

No767
Copy link
Member

@No767 No767 commented Jan 26, 2024

Summary

This PR implements an better reloader system, which superseeds the old FSWatcher module. This now also applies the ability to reload library modules, but files that depend on the module itself require an manual reload as it's simply too unstable to perform an deep reload.

Types of changes

What types of changes does your code introduce to Rodhaj
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

It's just simply impossible to do so in a stable way
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@No767 No767 mentioned this pull request Jan 26, 2024
5 tasks
@No767 No767 enabled auto-merge (squash) January 26, 2024 00:44
@No767 No767 disabled auto-merge January 26, 2024 00:44
@No767 No767 merged commit 90e78bb into main Jan 26, 2024
10 checks passed
@No767 No767 deleted the noelle/deepreload branch January 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant