timeouts by config and pop3 locking #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shppr
changed the title
| @@ -28,6 +31,12 @@ func (s *Server) Start() { | |||
| if err != nil { | |||
| panic(err.Error()) | |||
| } | |||
|
|
|||
| // set a timeout for the inbound server | |||
There was a problem hiding this comment.
This is not needed. It should be set through Server{} initialization in main.go.
There was a problem hiding this comment.
this is debatable, accept() doesnt know anything about the server, which is where the timeout should live. the only solution if the timeout is in the server struct is to make accept() part of Server{}'s method set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeouts:
Timeouts are in seconds in the config. This is the least coupled way I could think of to do this, anything else would require something like a timeout field in the server struct and then making the accept function a member of server as well.
Locks:
Lock on auth, unlock when client state is disconnected or on timeout if client was authed.