fix candlestick options

trash-and-fire · May 31, 2022 · 501c1b8 · 501c1b8
1 parent d75bb71
commit 501c1b8
Showing 1 changed file with 24 additions and 1 deletion.
diff --git a/packages/lib/src/internal/series.ts b/packages/lib/src/internal/series.ts
@@ -84,7 +84,16 @@ export function series<T extends SeriesActionParams>(target: ChartActionResult,
                 throw new TypeError('Can not change type of series in runtime. Report a bug please');
             }
 
-            subject.applyOptions(merge(clone(defaults), nextOptions));
+            const optionsToApply = merge(clone(defaults), nextOptions);
+
+            if (shouldHandleBorderCandlestickOptions(nextOptions)) {
+                delete optionsToApply.borderColor;
+            }
+            if (shouldHandleWickCandlestickOptions(nextOptions)) {
+                delete optionsToApply.wickColor;
+            }
+
+            subject.applyOptions(optionsToApply);
 
             if (!nextReactive) {
                 data = null;
@@ -161,3 +170,17 @@ function omit<T extends { reactive?: unknown; data: unknown; type: unknown }>(pa
     const {reactive, data, type, ...rest} = params;
     return rest;
 }
+
+function shouldHandleBorderCandlestickOptions(next: any): boolean {
+    if (next.borderColor === undefined) {
+        return next.borderUpColor !== undefined || next.borderDownColor !== undefined;
+    }
+    return false;
+}
+
+function shouldHandleWickCandlestickOptions(next: any): boolean {
+    if (next.wickColor === undefined) {
+        return next.wickUpColor !== undefined || next.wickDownColor !== undefined;
+    }
+    return false;
+}