Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert QoS-Information to AVP before putting them in TDV/SDC #442

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

RoadRunnr
Copy link
Member

QoS-Information in the session is keep in bps, however that can
overflow the 32bit allowed on some AAA AVPs. Run the values through
the ergw_aaa converter that takes care of the overflow before
initializing TDVs and SDCs with them.

QoS-Information in the session is keep in bps, however that can
overflow the 32bit allowed on some AAA AVPs. Run the values through
the ergw_aaa converter that takes care of the overflow before
initializing TDVs and SDCs with them.
@RoadRunnr RoadRunnr requested a review from a team as a code owner October 8, 2021 12:44
Copy link

@javiermtorres javiermtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a max value, so the CDR is encoded with it if the real value exceeds the max.

@RoadRunnr
Copy link
Member Author

Please add a max value, so the CDR is encoded with it if the real value exceeds the max.

ergw_aaa_diameter:qos_from_session does exactly that.

@RoadRunnr RoadRunnr merged commit a0a0c5d into master Oct 8, 2021
@RoadRunnr RoadRunnr deleted the fix/qos-in-tdv branch October 8, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants