fixed logging format, removed unnecessary quotation #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
GalaxyGorilla
force-pushed
the
log_format
branch
from
bd6ba98
to
f27ea34
Compare
| @@ -170,13 +170,12 @@ handle_call(_Call, _From, State) -> | |||
| %% @hidden | |||
| handle_info({?IDLE_TIMEOUT_MSG, TimerRef}, State = #state{timer = Timer, id = Id, mod = Mod}) | |||
| when Timer#timer.idle_timeout_ref == TimerRef -> | |||
| ?LOG_WARNING_reason(Mod, Id, "Hello handler with callback module '~p' and service id '~p' is going to stop due to idle timeout.", | |||
| [Mod, Id], {error, idle_timeout}, ?LOGID27), | |||
| ?LOG_WARNING_reason(Mod, Id, "~p : stopping due to idle timeout", [Mod], {error, idle_timeout}, ?LOGID27), | |||
There was a problem hiding this comment.
is "going to stop" and "stopping" here really the same?
|
👍 |
|
I ran into some trouble here with the dependency resolution of hex. See elixir-lang/elixir#3872. It seems the lager package has a flaw in the dependency specification. That's also the reason for the failing tests. |
GalaxyGorilla
force-pushed
the
log_format
branch
from
666a324
to
ce199a2
Compare
|
#80 fixed the goldrush dependency issue. |
GalaxyGorilla
force-pushed
the
log_format
branch
3 times, most recently
from
698154f
to
30c472f
Compare
GalaxyGorilla
force-pushed
the
log_format
branch
from
30c472f
to
4364c64
Compare
surik
added a commit
that referenced
this pull request
Oct 16, 2015
fixed logging format, removed unnecessary quotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant stuff for systemd's journal:
https://gist.github.com/GalaxyGorilla/added61676fc9620ae97