-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build UPG as an external VPP plugin #190
Conversation
ivan4th
commented
Nov 25, 2021
•
edited
Loading
edited
- use vpp-base image as the base for docker images
- produce dev-debug and dev-release images along with debug and release images
- produce deb artifacts along with the images
- enable interrupt-driven mode for e2e tests to reduce flakes
- check that the release mechanism is not broken in CI
Docker login is done through docker/login-action in CI
3a8bdf8
to
7fc04e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New vpp-base is required before we can merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After this PR the main README.md/Documentation has become completely outdated as most of the targets in the makefile do not exist anymore. vpp-base docker image is behind an authenticated harbor registry, it's not clear if that one is plain upstream or if still relies on patches (nor the respective upstream required version). |