-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping Node.js 0.6 support #1785
Comments
It's just stopped working today. However, it can be fixed simply by the instructions in https://twitter.com/npmjs/status/416298773241794560 : |
@ljharb Can you try putting that in your |
I absolutely don't want people who install my module to set strict-ssl to false. That command should only be run before tests, and only in node 0.6. Or are you just suggesting I do that for testing purposes? |
@ljharb The latter, of course. 0.6 is not in good shape, even in the eyes of the npm maintainers. I don't think it's worth anyone's time to make it work like it is a viable option for everyday use. |
I'll give that a try, thanks. I don't think anybody should be using node 0.6. However, every module that supports it, helps provide a clear upgrade path for people who are still using it in production - and there still are users of it. |
@BanzaiMan indeed, adding |
If that setting indeed solves it, then I think given Node.js 0.6's age, setting it in your .travis.yml is perfectly fine for the time being. |
@roidrage I'd be content with that for my own modules - how can I specify it only for node 0.6 in my travis.yml? Please note, however, that every single node project on 0.6 is broken - so if this isn't going to be fixed for everyone, then Travis has officially dropped support for node 0.6 with no notice, and will mark all modules as failed until 0.6 is skipped. That seems like a decision that shouldn't be made rashly. |
You can do this setting conditionally in your .travis.yml:
This is an acceptable workaround given that whether or not Node.js 0.6 continues to work at all is outside our control. |
Node 0.6.21 will continue to work forever - that's the point of semantic versioning. It's the registry that might change, and that protocol has been frozen for a long time now. Thanks! I'll give that setting a try. |
@ljharb Try putting everything in single quotes: before_install:
- '[ "${TRAVIS_NODE_VERSION}" = "0.6" ] && npm conf set strict-ssl false' |
k, that exits with a 1 when it's not node 0.6 - however before_install:
- '[ "${TRAVIS_NODE_VERSION}" = "0.6" ] && npm conf set strict-ssl false || true' worked! I still maintain that Travis CI should fix this automatically for everyone first, and then if it's going to drop node 0.6 support, do it with the proper notifications, and make sure not to run 0.6 builds anymore. Update: |
@BanzaiMan any response from the company on this? |
Well, there is no reason to cut off 0.6, but I don't think we will add a workaround for 0.6, either. If you want to test your code against 0.6, please employ the workaround suggested here. I'm going to leave this ticket open, so that it may be discovered by others who needs the workaround. |
Effectively that's the same as cutting it off, since pull requests against modules previously testing against 0.6 will all fail, so unless maintainers are very thorough and locate this issue, that will cause them to either stagnate or drop 0.6 support. |
We'll be sure to update our documentation to include both the workaround and a note that Node.js 0.6 is effectively EOL'd by now. |
I would be willing to accept a PR for either travis-cookbooks or travis-build which adds |
@joshk travis-ci/travis-build#188 Thanks! |
I merged the PR. |
Because the project now uses the "carrot operator" to specify some of its dependencies, NPM must be explicitly updated in the TravisCI environment before the build can succeed there. Sources: - https://github.com/npm/npm/wiki/Troubleshooting#travis-projects-using-08-cant-upgrade-to-npm-2 - travis-ci/travis-ci#1785 (comment)
See https://github.com/isaacs/npm/issues/4379#issuecomment-31183058
Node.js 0.6 can stop working at any given time.
The text was updated successfully, but these errors were encountered: