Nanosecond fix #70
Closed
Nanosecond fix #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 25, 2013 08:46
causes Time#at to return incorrect results. Explicitly call #utc before passing to Time#at. rails/rails#9403 Also added some tests to ensure correct time zones are returned.
for freezing an ActiveSupport::TimeWithZone.
|
Bump bump. Running into this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here was to keep nanoseconds when using ActiveSupport. Turns out there was an issue with ActiveSupport (rails/rails#9403) that is the real cause. I've ported that workaround into Timecop for now.
Also added some tests and did a little refactor on TimeStackItem#parse_time. I'm not sure that the Timecop.active_support config variable is necessary now at all, but I didn't want to totally pull it out since I wasn't sure about the use case.
If you'd like to only take part of these changes, or want the commits squashed, let me know and I'll tweak it.