Support convertion to PDF for markdown-preview-plus #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @travs,
Some of our users have wanted the ability to export PDF's from our fork of
markdown-preview
for a while (#48, https://github.com/Galadirith/markdown-preview-plus/issues/34 among others), I'm really sorry it's taken me so long to address this on my end.We would love it if you felt you could support MPP in your awesome package. I've put together the necessary changes in this PR. I'll make some more specific comments on the diff's but as a general summary
markdown-pdf
will be able to export to PDF's when eithermarkdown-preview
ormarkdown-preview-plus
is enabled, and in particular it also will export maths blocks which are a feature of our package.I've also added specs to make sure both use cases when either markdown preview package is enabled are tested. I really hope you don't mind the changes I made to your specs, I also removed
spec/markdown-pdf-view-spec.coffee
that seemed to test a module that no longer existed.Please let me know if you don't agree with any of my changes, the last thing I would want to do is cause any problems for you in your packages. Thanks @travs