Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jdbi2 to 3 #1688

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Upgrade Jdbi2 to 3 #1688

wants to merge 5 commits into from

Conversation

yoyama
Copy link
Contributor

@yoyama yoyama commented Jan 12, 2022

The last release of Jdbi2 is on 2017. It is 5 years ago.
We should migrate to Jdbi3.
This PR try to migrate to Jdbi3 experimentally.
Unfortunately Jdbi3 is not fully compatible with Jdbi2 and need to fix many codes.
So we should test carefully.
In addition Jdbi3 uses caffeine ver 3.x but it does not support Java8.
So force caffeine version to 2.x.

@yoyama yoyama requested a review from szyn January 12, 2022 07:38
@yoyama yoyama changed the title [WIP] Upgrade Jdbi2 to 3 Upgrade Jdbi2 to 3 Jan 13, 2022
@szyn szyn added this to the v0.10.5 milestone Jan 13, 2022
Copy link
Member

@szyn szyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve conflicts?

runtime 'org.antlr:stringtemplate:3.2.1' // Used by jdbi2's string template v3 at runtime
compile 'com.zaxxer:HikariCP:2.4.7'
compile 'com.h2database:h2:1.4.192'
compile 'org.postgresql:postgresql:9.4.1211'
compile 'org.postgresql:postgresql:42.3.1'
//compile 'org.postgresql:postgresql:9.4.1211'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about deleting this line?

@szyn szyn modified the milestones: v0.10.5, v0.10.6 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants