Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the s3_wait empty check example #1708

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix the s3_wait empty check example #1708

merged 1 commit into from
Feb 17, 2022

Conversation

akito19
Copy link
Member

@akito19 akito19 commented Feb 14, 2022

s3_wait operator shows an example for continue_on_timeout. However, it doesn't work when ${s3.last_object} is found.

+task1:
  s3_wait>: bucket/object
  timeout: 60s
  continue_on_timeout: true
+task2:
  if>: ${s3.last_object}
  _do:
    echo>: "No timeout"

So, update the example in order to pass the task2 even if the operator isn't timed out.

Copy link
Member

@szyn szyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@szyn szyn added the document label Feb 17, 2022
@szyn szyn merged commit a1d842c into master Feb 17, 2022
@szyn szyn deleted the fix-s3-wait-example branch February 17, 2022 04:58
@yoyama yoyama added this to the v0.10.5 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants