Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated highlight queries #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CalebLarsen
Copy link

Modified highlight queries to be to be more in-sync with language intent and query usage.

I also reordered some elements because my editor of choice is a little silly with ordering, but I don't believe it should negatively affect anyone.

If you disagree with any of the changes made, I'm open to feedback and discussion on them.

@amaanq
Copy link
Member

amaanq commented Jan 26, 2024

Hey, the queries here were originally tailored for Neovim - they should be adapted for any editor used, since they all use slightly different conventions, and some also flip the precedence of queries, some are first wins, some last wins.

What editor do you use? Neovim has changed some of the capture names lately to align with Helix and Github, but precedence is still split, neovim and zed use last wins, helix (and some others iirc) uses first wins

@CalebLarsen
Copy link
Author

I use helix which is rough if it's tailored for neovim. I'm not sure if any of the changes are actually applicable for neovim since I only investigated stuff in the helix repo.

Maybe it's best if I just keep this as a downstream fork to not mess with neovim users?

@amaanq
Copy link
Member

amaanq commented Feb 1, 2024

do you need a fork with different queries? (by all means, go ahead if you'd like to!) but I'm just curious what's the actual issue you're trying to solve or having troubles with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants