add null safety #3
Conversation
lib/scanner2.dart
Outdated
| deviceId: | ||
| new DeviceIdOptions(exact: _cameras[_useCamera].deviceId)))); | ||
| videoPromise = | ||
| getUserMedia(new UserMediaOptions(video: new VideoOptions(deviceId: new DeviceIdOptions(exact: _cameras?[_useCamera].deviceId)))); |
There was a problem hiding this comment.
Looks like these lines will go beyond the default dart formatting of 80 columns.
There was a problem hiding this comment.
ya, sorry.. i was removed that default dart formatting 80 col from my vscode
There was a problem hiding this comment.
Can you change it back, at least for this workspace in vscode? Otherwise, the next time anyone else edits these files these lines will change back.
There was a problem hiding this comment.
pls check again
pubspec.yaml
Outdated
| @@ -6,7 +6,7 @@ repository: https://github.com/treeder/jsqr_flutter | |||
| issue_tracker: https://github.com/treeder/jsqr_flutter/issues | |||
|
|
|||
| environment: | |||
| sdk: ">=2.7.0 <3.0.0" | |||
| sdk: '>=2.12.0-29.10.beta <3.0.0' | |||
| flutter: ">=1.20.0 <2.0.0" | |||
There was a problem hiding this comment.
Should let this upgrade to flutter 2 as well.
| flutter: ">=1.20.0 <2.0.0" | |
| flutter: ">=1.20.0 <3.0.0" |
There was a problem hiding this comment.
thanks, i've remove the maximum constraint
There was a problem hiding this comment.
Thanks again
you're welcome.
will you update versioning of this package in pub.dev ?
|
Thanks! Just a couple suggestions. |
No description provided.