Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated protocol version to tls #3

Merged
merged 4 commits into from
Oct 17, 2014
Merged

Conversation

formigarafa
Copy link

this will solve the issues with server not responding to sslv3 due to bug found in the protocol (POODLE)

this will solve the issues with server not responding to sslv3 due to bug found in the protocol (POODLE)
treeder added a commit that referenced this pull request Oct 17, 2014
updated protocol version to tls
@treeder treeder merged commit 6fdccdb into treeder:master Oct 17, 2014
@formigarafa formigarafa deleted the patch-1 branch October 18, 2014 22:26
@ab
Copy link

ab commented Oct 27, 2014

Pinning to TLSv1_2 probably isn't what you want to do here, since that will prevent clients from connecting to any servers that use a protocol other than TLS 1.2 (so no TLS 1.0, nor 1.1, nor future 1.3).

If you set any default value at all, it should probably be the confusingly named SSLv23, which is code for basically any TLS protocol version.

@treeder
Copy link
Owner

treeder commented Oct 27, 2014

Yep, we found that out the hard way. :) Already switched to SSLv23 in
1.8.1.

On Mon Oct 27 2014 at 11:04:19 AM Andy Brody notifications@github.com
wrote:

Pinning to TLSv1_2 probably isn't what you want to do here, since that
will prevent clients from connecting to any servers that use a protocol
other than TLS 1.2 (so no TLS 1.0, nor 1.1, nor future 1.3).

If you set any default value at all, it should probably be the confusingly
named SSLv23, which is code for basically any TLS protocol version.


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants