[BREAKING] X/Y coordinates can be given as input parameters (e.g. for testing!) & refactoring of GUI & CLI processing #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to distinct between GUI and CLI processing clearer - to be able to implement input of X/Y coordinates in the future
- incl. adjusting relevat unit tests
- functions to provide the functionality - call of them
- tests - country-name without "/" for X/Y coordinates
- in coding & tests - launch config: malta as x/y + multiple x/y comb
treee111
force-pushed
the
new-input-processing
branch
from
e8812b3
to
5d8efcf
Compare
treee111
force-pushed
the
new-input-processing
branch
from
c258d05
to
1e7f414
Compare
treee111
changed the title
treee111
added a commit
that referenced
this pull request
Apr 8, 2022
…testing!) & refactoring of GUI & CLI processing (#99) This PR makes it possible to provide X/Y coordinates via command line as input parameter to create the corresponding map * change start of the tool via two parsers - to distinct between GUI and CLI processing clearer - to be able to implement input of X/Y coordinates in the future * refactor input processing * adjust input processing (differentiate input further) - incl. adjusting relevat unit tests * implement input as X/Y coordinates - functions to provide the functionality - call of them * different changes - tests - country-name without "/" for X/Y coordinates * update documentation and launch config * PR review findings * implement multiple x/y combinations as input parameters - in coding & tests - launch config: malta as x/y + multiple x/y comb * update documentation for CLI usage in USAGE.md * do not log each .json file BREAKING CHANGE: The GUI and CLI of wahooMapsCreator will now be called differently than before: - `python wahoo_map_creator.py gui` and - `python wahoo_map_creator.py cli -co malta` This will ensure better control over the CLI input parameters, help messages and is more consistent now!
treee111
added a commit
that referenced
this pull request
Apr 8, 2022
…testing!) & refactoring of GUI & CLI processing (#99) This PR makes it possible to provide X/Y coordinates via command line as input parameter to create the corresponding map * change start of the tool via two parsers - to distinct between GUI and CLI processing clearer - to be able to implement input of X/Y coordinates in the future * refactor input processing * adjust input processing (differentiate input further) - incl. adjusting relevat unit tests * implement input as X/Y coordinates - functions to provide the functionality - call of them * different changes - tests - country-name without "/" for X/Y coordinates * update documentation and launch config * PR review findings * implement multiple x/y combinations as input parameters - in coding & tests - launch config: malta as x/y + multiple x/y comb * update documentation for CLI usage in USAGE.md * do not log each .json file BREAKING CHANGE: The GUI and CLI of wahooMapsCreator will now be called differently than before: - `python wahoo_map_creator.py gui` and - `python wahoo_map_creator.py cli -co malta` This will ensure better control over the CLI input parameters, help messages and is more consistent now!
treee111
added a commit
that referenced
this pull request
Apr 9, 2022
… testing!) & refactoring of GUI & CLI processing (#99) This PR makes it possible to provide X/Y coordinates via command line as input parameter to create the corresponding map * change start of the tool via two parsers - to distinct between GUI and CLI processing clearer - to be able to implement input of X/Y coordinates in the future * refactor input processing * adjust input processing (differentiate input further) - incl. adjusting relevat unit tests * implement input as X/Y coordinates - functions to provide the functionality - call of them * different changes - tests - country-name without "/" for X/Y coordinates * update documentation and launch config * PR review findings * implement multiple x/y combinations as input parameters - in coding & tests - launch config: malta as x/y + multiple x/y comb * update documentation for CLI usage in USAGE.md * do not log each .json file BREAKING CHANGE: The GUI and CLI of wahooMapsCreator will now be called differently than before: - `python wahoo_map_creator.py gui` and - `python wahoo_map_creator.py cli -co malta` This will ensure better control over the CLI input parameters, help messages and is more consistent now!
treee111
changed the title
4 tasks
treee111
added a commit
that referenced
this pull request
Apr 11, 2022
…on-file with tile(s). It is replaced by #99 (#105) * remove primary input option "-fi" json-file with tile - remove the CLI input parameter across the repo - adjust unittests accordingly - delete the whole /tests/jsons folder * tidy up launch config - remove -fi entries for .json files - delete unused entries
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR…
Considerations and implementations
This PR brings a foundation to implement #100 and #89 by
How to test
Pull Request Checklist