Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantize to prevent leaks with float32 #435

Merged
merged 2 commits into from
Jun 14, 2022
Merged

quantize to prevent leaks with float32 #435

merged 2 commits into from
Jun 14, 2022

Conversation

guzba
Copy link
Collaborator

@guzba guzba commented Jun 10, 2022

now that we have split parsing an svg from rendering it, i'd like to focus the benchmark just on the rendering for the time being. the parsing is it's own thing to benchmark but the rendering is the vast majority of time.

before:

svg render ........................ 12.716 ms     12.755 ms    ±0.024   x392

after:

svg render ........................ 12.539 ms     12.570 ms    ±0.020   x398

these timings are using treeform/vmath#54
both have no leaks with fuzz_leaks.nim or fuzz_leaks2.nim
no change in output quality (we can't do more than 256 steps of aa anyway)

this does slightly change svg output so many of the test rendered files change. im not committing them here since i have other changes that will affect all files and we've talked about a different way of handling test files as well

@treeform treeform merged commit 076d7a3 into treeform:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants