adding reconnect to publisher #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the connection fails with rong lunning processes. this should fix the issue and reconnect when connection is lost.
cleentfaar
approved these changes
Mar 3, 2020
|
|
||
| if (!$this->exchange->getConnection()->isConnected()) { | ||
| $this->exchange->getConnection()->reconnect(); | ||
| } |
There was a problem hiding this comment.
does this really help? if I look into the called method it just returns the status code of the last command that was sent, which doesn't help if the connection is closed after that
pkruithof
reviewed
Mar 3, 2020
| @@ -59,7 +59,11 @@ public function publish(Message $message, \DateTime $date = null, $flags = Excha | |||
| $body = $message->getBody(); | |||
| $route = $message->getRoutingKey(); | |||
| $props = $message->getProperties()->toArray(); | |||
|
|
|||
|
|
|||
| if (!$this->exchange->getConnection()->isConnected()) { | |||
There was a problem hiding this comment.
I don't think this is the right place for this. The publisher just needs to publish. This fix is useful in a specific context (long-running processes), I think you should incorporate it into your process instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the connection fails with rong lunning processes. this should fix the issue and reconnect when connection is lost.