Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treehouses checksignal #72

Closed
wants to merge 5 commits into from
Closed

treehouses checksignal #72

wants to merge 5 commits into from

Conversation

i5o
Copy link
Collaborator

@i5o i5o commented May 31, 2018

this pull requests replaces #58 by @TerrenceEJ
and by #58 (comment)
now this is the output

pi@raspberrypi:~ $ treehouses checksignal
Signal level=-47  
pi@raspberrypi:~ $ 

@dogi dogi requested a review from TerrenceEJ May 31, 2018 00:22
Copy link
Member

@TerrenceEJ TerrenceEJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Member

@xyb994 xyb994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should keep dBm in the output. Still might want to explain what the numbers means somewhere.

@i5o
Copy link
Collaborator Author

i5o commented Jun 1, 2018

@TerrenceEJ that's up to you, do you need dBm in the app, or do you remove it on your code?

@TerrenceEJ
Copy link
Member

TerrenceEJ commented Jun 1, 2018 via email

@i5o
Copy link
Collaborator Author

i5o commented Jun 1, 2018

Done

@i5o i5o added the ready to merge Pull request has been approved and tested label Jul 25, 2018
@dogi dogi removed the ready to merge Pull request has been approved and tested label Jul 25, 2018
Copy link
Member

@dogi dogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checksignal is maybe not the best word ....

@dogi
Copy link
Member

dogi commented Nov 19, 2018

  • needs to rebased ;)
  • new command name wifidbm or wifistrength ... like later one more ;)
  • extented help is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants