-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treehouses checksignal #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should keep dBm
in the output. Still might want to explain what the numbers means somewhere.
@TerrenceEJ that's up to you, do you need dBm in the app, or do you remove it on your code? |
If you could change it to use dbm, that would be great
…On Fri, Jun 1, 2018, 6:39 PM Ignacio Rodríguez ***@***.***> wrote:
@TerrenceEJ <https://github.com/TerrenceEJ> that's up to you, do you need
dBm in the app, or do you remove it on your code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXaLe0_dgHqbmLnbj-5uL1T1oh2RyTaNks5t4cKhgaJpZM4UUMYD>
.
|
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checksignal is maybe not the best word ....
|
this pull requests replaces #58 by @TerrenceEJ
and by #58 (comment)
now this is the output