API-402: Add last resort CSV decoder for slice types #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work for most array types. The only issue I can think of off hand is the []string type. Do we want to break &foo=a,b,c&foo=d into ["a","b","c","d"] or ["a,b,c", "d"]? For now that is the second option which should not break any backwards compatability
|
Since this has already been merged upstream, and it's the only thing that we don't have on our fork, can/should we just reset our master to upstream? |
|
I updated our master to upstream which as the branched merged in. Closing this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work for most array types. The only issue
I can think of off hand is the []string type. Do we want to
break &foo=a,b,c&foo=d into ["a","b","c","d"] or ["a,b,c", "d"]?
For now that is the second option which should not break any
backwards compatability
I also submitted this pr to upstream gorilla/schema