Pull Requests: Add closed date #8223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
exclude-changelog
|
♻️ PR Preview ad5838e has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
itaigilo
approved these changes
Sep 25, 2024
api/swagger.yml
Outdated
| @@ -1770,6 +1770,9 @@ components: | |||
| merged_commit_id: | |||
| type: string | |||
| description: the commit id of merged PRs | |||
| close_date: | |||
There was a problem hiding this comment.
Please add description, so it will be clear that it's relevant also for merged PRs, not only closed ones.
There was a problem hiding this comment.
Also, if we have merged_commit_id -
Shouldn't this be closed_date?
Co-authored-by: itaigilo <itai.gilo@treeverse.io>
Co-authored-by: itaigilo <itai.gilo@treeverse.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8222
Change Description
Add close date to pull request
Testing Details
Added unit tests