-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit chart if all values are zero #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I was a bit worried that omitting diagrams might be confusing in some cases, but I agree that the user interface is clearer when unused diagrams are omitted. I think this is a good improvement.
fed192b
to
4e6c1ac
Compare
@treiher I applied the suggested changes and also fixed some complaints that clippy had. Do you know what the issue with the frontend checks is? This happens to me on main, too, and doesn't seem to be related to my changes. |
30e61c4
to
469a83a
Compare
That's annoying! Thanks for looking into that issue. The tests succeed for me now, too. |
469a83a
to
3dc9742
Compare
Do not show a chart if all values of the data series(es) are zero. Optionally, print a text in place of the chart.
This makes the UI clearer if certain features are not being used (like RPE).
Don't hesitate to request (or make) changes if you think this should be solved differently!