-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade postgres and bytes dependencies. #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2021
Licenser
previously approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 LGTM 👍
The PR in question is merged and we are now on async std 1.9 does that unblock? |
Licenser
force-pushed
the
postgres-dep-upgrade
branch
2 times, most recently
from
January 18, 2021 11:39
77ca248
to
f35a87a
Compare
Licenser
previously approved these changes
Jan 18, 2021
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
mfelsche
force-pushed
the
postgres-dep-upgrade
branch
from
January 18, 2021 12:44
f35a87a
to
3fa9048
Compare
Licenser
previously approved these changes
Jan 18, 2021
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Licenser
previously approved these changes
Jan 18, 2021
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Licenser
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Upgrade postgres deps and as transitive dependency also bytes.
This pulls in tokio 1.0 but async-std is not yet compatible. We need to wait for async-rs/async-std#924 to be merged and released. Gotta keep this as draft until then.
Related
Checklist