Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Legend scroll #716

Merged
merged 41 commits into from Oct 23, 2023
Merged

Conversation

mbauchet
Copy link
Collaborator

@mbauchet mbauchet commented Sep 28, 2023

Description
Add scroll to legend component

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):
Capture d’écran 2023-10-19 à 18 54 41

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

severinlandolt and others added 10 commits October 17, 2023 21:44
* update recharts

* feat: added new interval props
* fix search issues on MultiSelect

- Add new value to keep availableOptions to search
- Reset the searchQuery when onBlur the list options
- Keep options selected when the user is searching
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 11:28pm

@severinlandolt
Copy link
Member

severinlandolt commented Oct 19, 2023

@mbauchet Changed the target branch to beta and resolved the conflicts. Could you fill out the PR form and include a screenshot and then mark it ready for review? Would be very cool to include this in 3.10 ✨

@severinlandolt
Copy link
Member

@mbauchet Just testend the thing, you are the 🐐

@severinlandolt
Copy link
Member

Candidate for 3.11.

@severinlandolt severinlandolt changed the base branch from main to beta October 23, 2023 23:22
@severinlandolt severinlandolt removed the request for review from christopherkindl October 23, 2023 23:28
@severinlandolt severinlandolt merged commit e8929e8 into tremorlabs:beta Oct 23, 2023
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.11.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

severinlandolt added a commit that referenced this pull request Nov 6, 2023
* fix: tab colors (#768)

* feat: Legend scroll (#716)

* Add label rotation

* fix: Padding improvement when no axes are shown (#774)

* fix: value test circle

* fix: Transitions Input elements (#776)

* feat: Textarea (#778)

* feat: add spark charts (bar, line, area) (#759)

---------

Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: Severin Landolt <sev.landolt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Under Consideration Has potentially wider implications which are being discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants