Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Textarea #778

Merged
merged 7 commits into from Oct 27, 2023
Merged

feat: Textarea #778

merged 7 commits into from Oct 27, 2023

Conversation

severinlandolt
Copy link
Member

@severinlandolt severinlandolt commented Oct 25, 2023

Description

This PR adds a new Textarea component.

Closes #642
Closes #363
Closes #670

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Storybook

Screenshots (if appropriate):

CleanShot 2023-10-25 at 22 18 42@2x

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 9:34pm

@severinlandolt severinlandolt changed the title Feat/textarea feat: Textarea Oct 25, 2023
@severinlandolt
Copy link
Member Author

@mbauchet The Default story of Textarea has no value and no defaultValue. Hence, and according to the logic in the code with const hasSelection = hasValue(value || defaultValue); it does not have a selection. This results in the text not being rendered in the correct color, despite typing something into the textarea and focusing the thing → The text is tremor-content but should be tremor-content-emphasis. The general idea is:

  • Textarea focused: text-tremor-content-emphasis
  • Textarea blur: text-tremor-content

What I tried and worked is adding: focus:text-tremor-content-emphasis to the textarea, but would be cooler to have it solved with the getSelectButtonColorsfunction.

Do you have a smart idea how to fix that?

Generally happy to have you reviewing the component :)

@severinlandolt severinlandolt merged commit 4e1f1a2 into beta Oct 27, 2023
6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.11.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@severinlandolt severinlandolt deleted the feat/textarea branch October 30, 2023 00:05
severinlandolt added a commit that referenced this pull request Nov 6, 2023
* fix: tab colors (#768)

* feat: Legend scroll (#716)

* Add label rotation

* fix: Padding improvement when no axes are shown (#774)

* fix: value test circle

* fix: Transitions Input elements (#776)

* feat: Textarea (#778)

* feat: add spark charts (bar, line, area) (#759)

---------

Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: Severin Landolt <sev.landolt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: <TextArea/> component [Feature]: Need Textarea Component Feature request: TextArea
2 participants