Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add spark charts (bar, line, area) #759

Merged
merged 11 commits into from Oct 31, 2023
Merged

feat: add spark charts (bar, line, area) #759

merged 11 commits into from Oct 31, 2023

Conversation

mbauchet
Copy link
Collaborator

Description

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 8:07pm

@mbauchet mbauchet changed the title fe: add spark charts (bar, line, area) feat: add spark charts (bar, line, area) Oct 16, 2023
@mbauchet mbauchet marked this pull request as ready for review October 19, 2023 10:01
@severinlandolt severinlandolt changed the base branch from main to beta October 24, 2023 14:20
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Oct 26, 2023
@severinlandolt
Copy link
Member

@christopherkindl Ready for your review :)

@severinlandolt severinlandolt merged commit 764e816 into tremorlabs:beta Oct 31, 2023
5 checks passed
@severinlandolt
Copy link
Member

Thank you @mbauchet!

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.11.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

severinlandolt added a commit that referenced this pull request Nov 6, 2023
@severinlandolt @mbauchet
feat: legendSlider, Textarea, Spark Charts (#789)
33c98fe 
* fix: tab colors (#768)

* feat: Legend scroll (#716)

* Add label rotation

* fix: Padding improvement when no axes are shown (#774)

* fix: value test circle

* fix: Transitions Input elements (#776)

* feat: Textarea (#778)

* feat: add spark charts (bar, line, area) (#759)

---------

Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: Severin Landolt <sev.landolt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severinlandolt severinlandolt severinlandolt approved these changes

@christopherkindl christopherkindl Awaiting requested review from christopherkindl

Assignees
No one assigned
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbauchet @severinlandolt