Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow link patterns to be passed via extras dict #512

Merged
merged 2 commits into from
May 28, 2023

Conversation

Crozzers
Copy link
Contributor

This PR allows the user to pass in link patterns via the extras argument.
Previously, the user would have to remember to set two arguments correctly:

# correct
markdown(text, extras=['link-patterns'], link_patterns=[...])
# incorrect
markdown(text, link_patterns=[...])  # doesn't raise but doesn't activate extra
markdown(text, extras=['link-patterns'])  # raises error
markdown(text, extras={'link-patterns': [...]})  # raises error

This PR enables that last use case

@nicholasserra
Copy link
Collaborator

LGTM thanks for your continued support

@nicholasserra nicholasserra merged commit 2c092d1 into trentm:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants